29 support all provider attributes in .tf files
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now support setting these two variables in the proper place for a terraform configuration rather than relying on env vars to do it for us.
This allows allsettings to be set through the `.tf` file now. We also changed the oss tests to include SSL as well.
izgeri
suggested changes
Apr 24, 2020
izgeri
reviewed
Apr 27, 2020
izgeri
suggested changes
Apr 27, 2020
There was a problem hiding this comment.
just one last comment to add some clarity to the README
it's worth also noting that as of right now we don't have tests for when there is a mix of provider / env configuration settings, or for when the ssl_cert_path is used - is there a way to add unit tests for that? if it's not straightforward, should we file a follow-up github issue?
sgnn7
force-pushed
the
29-support-all-provider-attributes
branch
from
13339dd to
93bcc1f
Compare
Examples used completely different info between them so correlation was difficult. This change ensures that all of them use the same info.
sgnn7
force-pushed
the
29-support-all-provider-attributes
branch
from
93bcc1f to
f8a691d
Compare
izgeri
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
.tffiles:appliance_urlaccountssl_certssl_cert_file.tfvariablesConnected to #29