Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme update #112

Closed
wants to merge 7 commits into from
Closed

Readme update #112

wants to merge 7 commits into from

Conversation

Nirupma-Verma
Copy link
Contributor

Desired Outcome

*Read.md updated for explaining the usage of provider directly from registry.terraform.io and access token authentication for example for fetching secret

Implemented Changes

Describe how the desired outcome above has been achieved with this PR. In
particular, consider:

  • To support access token authentication fix is being provided in conjur-api-go (Access token change conjur-api-go#137)
  • Read.md updated with example of fetching secret using registry.terraform.io and access token

Connected Issue/Story

Resolves #[https://github.com//issues/99
https://github.com//issues/69
]

CyberArk internal issue link: insert issue ID

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@Nirupma-Verma Nirupma-Verma requested a review from a team as a code owner October 19, 2022 19:50
@gcandiloro
Copy link

Not sure if my leaving a comment will help you add me as a reviewer, but it looks like I can leave feedback as a comment.

Copy link

@gcandiloro gcandiloro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor suggestions, all else looks good.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants