Bug fix: allow ->* without a space #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and * - add new lexical symbols for <- and <-> - reshape the pgq.y grammar rules to use these
now, we allow them so the <-> and <- symbols were removed again. This change of thought was triggered by the mayhem the new lexical symbols were causing: ================================================================================ Query unexpectedly failed (test/optimizer/move_constants.test:101) ================================================================================ EXPLAIN SELECT -1*X<-5 FROM test; ================================================================================ Actual result: Parser Error: syntax error at or near "<-" LINE 1: EXPLAIN SELECT -1*X<-5 FROM test but the main result of this PR is still: you can now type ->* without spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cwida/duckpgq-extension#146
A bug we previously experienced was that there had to be a space between (
->or-) and*to be properly parsed. This PR fixes that.