Skip to content

Commit

Permalink
Upped Python version used on windows, and documented that workflow.ym…
Browse files Browse the repository at this point in the history
…l needs to be checked.
  • Loading branch information
jackjansen committed Jan 15, 2025
1 parent 4b89515 commit 29f85c6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Install correct Python version
uses: actions/setup-python@v5
with:
python-version: '3.11'
python-version: '3.12'
- name: Pre-install (Windows)
shell: pwsh
run: |
Expand Down
1 change: 1 addition & 0 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,7 @@ When creating a new release, ensure the following have been done
- Update `scripts/install-3rdparty-full-win1034.ps1` with the best Python version.
- Update `scripts/install-3rdparty-osx1015.sh` with the best Python version.
- Check the Ubuntu install-3rdparty scripts for which Python they install.
- Check `.github/workflows/build.yml` for the Python versions used.

- Dependencies for the `.deb` installer for apt/Ubuntu need to be updated. There may be better ways to do this, but this works:
- On the targeted Ubuntu, check out and edit `CMakeFiles/CwipcInstallers.cmake`
Expand Down

0 comments on commit 29f85c6

Please sign in to comment.