-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ambiguous parameteric datatype constructors #106
Open
ajreynol
wants to merge
31
commits into
main
Choose a base branch
from
paramDt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures ethos can properly parse and type check ambiguous datatype constructors in the SMT-LIB 2.X standard.
Say a datatype constructor is "ambiguous" if it of type:
where some free parameter of T is not contained in the free parameters of T1...Tn. (Note n may be 0).
To support ambiguous datatype constructors in Eunoia/Ethos, we require several things.
(1) Their declared type is made unambiguous.
In particular, all ambiguous datatype constructors are instead defined to be of type:
This is done automatically, so that for:
If the user asked for the types of the constructors, they would get:
(2) Type annotations on datatype constructors are treated as opaque applications.
We expect
(as nil (List Int))
to be a constant of type(List Int)
.This is implemented by parsing
(as nil (List Int))
as(_ nil (List Int))
, where this is an "opaque" application.Effectively, this means that
(_ nil (List Int))
is a constant symbol that is indexed by its type.Note in this understanding, Ethos is overloading the meaning of the
as
operator in SMT-LIB for two purposes. First, for overloaded symbols which is a way of determining which symbol is being referred to, and for parameteric datatypes where it is interpreted as being an (opaque) argument. Only the latter is implemented currently.(3) Extend the semantics of eo::dt_selectors.
Currently,
(eo::dt_selectors c)
evaluates the list of selectors only if c is a constructor constant.To handle ambiguous datatype constructors, we also say that
(eo::dt_selectors (_ c T))
evaluates to the list of selectors ofc
.Example:
(4) Extend the semantics of eo::dt_constructors.
Currently,
(eo::dt_constructors T)
evaluates the list of constructors only ifT
is an (uninstantiated) datatype type.We extend this for instantiated datatypes to automatically apply the appropriate annotations. For example,
(5) The SMT-LIB syntax
as
is now parsed in Ethos (in all contexts).Note this only is processed when applied to ambiguous datatype constructors. Processing
as
for symbol disambiguation is still TODO.