r/project: ensuring that all fields are set #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required as of Terraform 0.12, else these are omitted from the state
When Terraform invokes a provider via the Create method, the 'isNew' attribute will be set - so these calls are superflurious
This makes the drift-detection consistent across all resources, so that Terraform is able to detect when these resources have been deleted outside of Terraform and require recreation.
cvbarros
approved these changes
Jun 11, 2020
|
A rebase here with solving the conflicts and this will be merged 🚀 |
|
This should resolve #92 |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that all fields within the
teamcity_projectresource have a value - which is required in Terraform 0.12.There's a couple of other changes in here too, since I was passing through it felt worth making them everywhere at once, I hope you don't mind:
terraform pland.MarkNewResource- when Terraform calls into a Create function, the "isNew" field in the resource (which is what MarkNewResource sets) is set to true - so this call is superfluous and can be removed