Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trurl: add --curl to only count as valid URLs supported by libcurl #241

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

emanuele6
Copy link
Collaborator

I would prefer that trurl rejected URLs with schemes not supported by libcurl when I use it in combination with curl.

@emanuele6
Copy link
Collaborator Author

emanuele6 commented Oct 18, 2023

Hmm, on CI the error message is This libcurl build doesn't support the given URL scheme [foo://bar], but it is Unsupported URL scheme [foo://bar] with libcurl 8.4.0. :/
I have to use "stderr": true.

@bagder
Copy link
Member

bagder commented Oct 27, 2023

Maybe we should do something more generic for the error message checks...

@emanuele6
Copy link
Collaborator Author

Resolved conflicts, and rebased to get the fix from #240

@bagder bagder merged commit 8251637 into curl:master Oct 30, 2023
9 checks passed
@bagder
Copy link
Member

bagder commented Oct 30, 2023

Thanks!

@emanuele6 emanuele6 deleted the curl branch October 30, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants