-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Puny2idn #231
Puny2idn #231
Conversation
@bagder Currently this branch returns |
I agree. We can possibly output a warning (?) but I think it makes sense to treat Does it make sense with how the libcurl API works or do we need to poke anything in that end as well? |
libcurl should be fine as is, I have a commit on my personal computer that behaves this way that I can push up when I get home. Currently libcurl reports an error on conversion which it should, and trurl (on the commit I haven't pushed up) is handling the error by simply returning original url. I can make sure it throws a warning as well. |
I'm not entirely sure on that warnings is a good idea, but I figure we can try it. I suspect that if we introduce "warnings" for some things we probably also need to provide a way to hush them up... |
hm... we already have trurl_warnf(option *o, char *fmt, ...)
{
...
if(!o->supress_warnings) {
warnf(fmt, ap);
}
} |
Yes, I think that is very sensible. |
This PR adds a few new features around converting punycode to IDN. specifically
--as-idn
andidn:
option in the get syntax.The development for this work was done using the latest version of curl from master. If you link against this version you should be able use these features (though trurl works with out them).
There is a large uptick in memory related issue - either double frees or curl_free not cleaning everything up. I addressed some of them but I am having trouble identifying the others, so this may take more investigation.