Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tgenv-list-remote #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NathanTindle
Copy link

It would be very helpful to update tgenv-list-remote to return more than 100 versions. This would assist me in a migration from older versions of terragrunt that do not show due to the limitation of github api having a max of 100 for per_page.

Update tgenv-list-remote to return more than 100 versions
fi

echo $print | grep -o -E "[0-9]+\.[0-9]+\.[0-9]+(-(rc|beta)[0-9]+)?" | uniq
for ((i=1;i<=10;i++))
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just thinking at the moment this is limited to 10 pages of results for Terragrunt releases. It might be better to increase this as Terragrunt seems to be a fast moving project.

@NathanTindle
Copy link
Author

I did not see there is already an open pull request for this same issue the other fix is probably better as I does not have the limitation of page numbers

@sajidk1
Copy link

sajidk1 commented May 27, 2021

@NathanTindle unfortunately, you won't get any traction with this PR. See #19

@NathanTindle
Copy link
Author

Thank you @sajid-khan-js you are probably right. I will just use my own fork for now. Just need it for a migration so will probably be removed sometime in the future

@jpalomaki
Copy link

@NathanTindle Have you tried using git ls-remote --tags https://github.com/gruntwork-io/terragrunt to fetch versions instead?

@NathanTindle
Copy link
Author

@jpalomaki I had not seen this thank you for the info. I will take a look

@iokiwi
Copy link

iokiwi commented Dec 20, 2022

@NathanTindle @weyderfs has forked and is trying to reboot this project over at https://github.com/tgent/tgenv (see #45)

Consider raising your MR over there? Otherwise do you mind If I move this over?

@iokiwi
Copy link

iokiwi commented Dec 21, 2022

@NathanTindle I've reimplemented this PR incorporating suggestions from the comments over at in tgenv/tgenv#2

austinguo550 pushed a commit to Affirm/tgenv that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants