-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tgenv-list-remote #25
base: master
Are you sure you want to change the base?
Conversation
Update tgenv-list-remote to return more than 100 versions
fi | ||
|
||
echo $print | grep -o -E "[0-9]+\.[0-9]+\.[0-9]+(-(rc|beta)[0-9]+)?" | uniq | ||
for ((i=1;i<=10;i++)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just thinking at the moment this is limited to 10 pages of results for Terragrunt releases. It might be better to increase this as Terragrunt seems to be a fast moving project.
I did not see there is already an open pull request for this same issue the other fix is probably better as I does not have the limitation of page numbers |
@NathanTindle unfortunately, you won't get any traction with this PR. See #19 |
Thank you @sajid-khan-js you are probably right. I will just use my own fork for now. Just need it for a migration so will probably be removed sometime in the future |
@NathanTindle Have you tried using |
@jpalomaki I had not seen this thank you for the info. I will take a look |
@NathanTindle @weyderfs has forked and is trying to reboot this project over at https://github.com/tgent/tgenv (see #45) Consider raising your MR over there? Otherwise do you mind If I move this over? |
@NathanTindle I've reimplemented this PR incorporating suggestions from the comments over at in tgenv/tgenv#2 |
It would be very helpful to update tgenv-list-remote to return more than 100 versions. This would assist me in a migration from older versions of terragrunt that do not show due to the limitation of github api having a max of 100 for per_page.