Update for PySide6 Support. #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert Pyside Enum references to long form to adapt to breaking changes from PySide5->PySide6 See FAQ for more details https://www.pythonguis.com/faq/pyqt6-vs-pyside6/
cunnane
approved these changes
Jan 2, 2025
|
Thanks! No need to compile all of xlOil to check this, I think you've done enough. |
|
Thanks for approving! I don't have write access so I'll leave it to you to merge? |
…details. Hopefully shedding more light as to why the call failed.
…itional details." This reverts commit 620bfb2.
|
reverted my accidental additional commit to keep the PR clean |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Steven, hopefully an easy one to review!
Convert Pyside Enum references to long form to adapt to breaking changes from PySide5->PySide6 See FAQ for more details https://www.pythonguis.com/faq/pyqt6-vs-pyside6/
I ran the manual test
PythonTestUI.xlsmand confirmed the panes still worked.I used vscode so didn't quite manage to compile locally but rather tested with local edit of a 0.19.1 installation which worked alright.