-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: HomePage of User #701
Open
baboon-king
wants to merge
24
commits into
main
Choose a base branch
from
feat/user-prefile
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baboon-king
force-pushed
the
feat/user-prefile
branch
from
May 24, 2024 09:29
fe67747
to
8eadfe0
Compare
baboon-king
force-pushed
the
feat/user-prefile
branch
from
May 24, 2024 11:48
d345aa3
to
25366ac
Compare
cuixiaorui
reviewed
May 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
功能上需要改进的点
- 用户访问 / 也可以看到自己的 home ,不需要在跳转
- 前端 url 里面去掉 user , 和 GitHub 对齐
- 例如: earthworm.cuixueshe.com/cxr 就可以看到用户的主页(现在是 /user/cxr)
- 访问别人主页的时候 不应该显示 “更多的课程包”
apps/api/src/user-course-progress/user-course-progress.controller.ts
Outdated
Show resolved
Hide resolved
baboon-king
force-pushed
the
feat/user-prefile
branch
4 times, most recently
from
May 28, 2024 11:18
2512845
to
5297388
Compare
baboon-king
force-pushed
the
feat/user-prefile
branch
2 times, most recently
from
June 3, 2024 01:37
2191774
to
ed363af
Compare
Hello, My username is login (dog head |
baboon-king
force-pushed
the
feat/user-prefile
branch
from
June 17, 2024 01:37
ed363af
to
1e15dc0
Compare
Don't worry! It's OK! |
baboon-king
force-pushed
the
feat/user-prefile
branch
from
June 25, 2024 09:05
1e15dc0
to
abb370d
Compare
baboon-king
force-pushed
the
feat/user-prefile
branch
from
July 4, 2024 09:18
abb370d
to
c8d3c2c
Compare
baboon-king
force-pushed
the
feat/user-prefile
branch
from
July 16, 2024 09:54
c8d3c2c
to
ba2bb36
Compare
baboon-king
force-pushed
the
feat/user-prefile
branch
from
July 21, 2024 18:09
ba2bb36
to
a0660bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
使用
/user/:username/:username 可以访问某个用户的主页。包含
个人信息
最近学习的课程
打卡日历图
等公开的个人数据