Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HomePage of User #701

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

feat: HomePage of User #701

wants to merge 24 commits into from

Conversation

baboon-king
Copy link
Collaborator

@baboon-king baboon-king commented May 24, 2024

使用 /user/:username /:username 可以访问某个用户的主页。
包含 个人信息 最近学习的课程 打卡日历图 等公开的个人数据

  • 相关API增加
  • 界面相关变更

@baboon-king baboon-king marked this pull request as ready for review May 24, 2024 11:41
@baboon-king baboon-king requested a review from cuixiaorui May 24, 2024 11:54
Copy link
Contributor

@cuixiaorui cuixiaorui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

功能上需要改进的点

  1. 用户访问 / 也可以看到自己的 home ,不需要在跳转
  2. 前端 url 里面去掉 user , 和 GitHub 对齐
    • 例如: earthworm.cuixueshe.com/cxr 就可以看到用户的主页(现在是 /user/cxr)
  3. 访问别人主页的时候 不应该显示 “更多的课程包”

apps/api/src/user/user.service.ts Outdated Show resolved Hide resolved
apps/client/api/userCourseProgress.ts Outdated Show resolved Hide resolved
apps/client/components/Home/RecentCoursePack.vue Outdated Show resolved Hide resolved
apps/client/components/Home/index.vue Outdated Show resolved Hide resolved
apps/client/components/rank/RankingItem.vue Outdated Show resolved Hide resolved
apps/client/composables/learnRecord.ts Outdated Show resolved Hide resolved
apps/client/composables/learnRecord.ts Outdated Show resolved Hide resolved
@baboon-king baboon-king force-pushed the feat/user-prefile branch 4 times, most recently from 2512845 to 5297388 Compare May 28, 2024 11:18
@fengstats fengstats requested review from cuixiaorui and fengstats May 29, 2024 22:12
@baboon-king baboon-king force-pushed the feat/user-prefile branch 2 times, most recently from 2191774 to ed363af Compare June 3, 2024 01:37
@AngryChocobo
Copy link

前端 url 里面去掉 user , 和 GitHub 对齐
earthworm.cuixueshe.com/cxr 就可以看到用户的主页(现在是 /user/cxr)

Hello, My username is login (dog head

@baboon-king
Copy link
Collaborator Author

前端 url 里面去掉 user , 和 GitHub 对齐
earthworm.cuixueshe.com/cxr 就可以看到用户的主页(现在是 /user/cxr)

Hello, My username is login (dog head

Don't worry! It's OK!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants