Skip to content

Commit

Permalink
all: remove obsolete TODOs assigned to me
Browse files Browse the repository at this point in the history
`cue import --dry-run` was added in https://cuelang.org/cl/1198967
and encoding_jsonl.txtar was simplified as part of that change;
I completely forgot to remove the TODO as well.

The `cue mod edit -langversion` TODO was similarly fixed by
https://cuelang.org/cl/1196822, and since the TODO was only a reminder
and the test doesn't need to use it, we can simply remove it.

Finally, we reverted the toml API from ast.Node to ast.Expr in
https://cuelang.org/cl/1198540, so the TODO about cue.Context
not providing a method to build ast.Node is no longer relevant.

Signed-off-by: Daniel Martí <[email protected]>
Change-Id: I07efc2a34d2a17efdc224896cd4f3a9b869c0117
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1200021
Unity-Result: CUE porcuepine <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>
Reviewed-by: Matthew Sackman <[email protected]>
  • Loading branch information
mvdan committed Aug 27, 2024
1 parent 0389e8a commit eeec3f5
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 5 deletions.
2 changes: 0 additions & 2 deletions cmd/cue/cmd/testdata/script/encoding_jsonl.txtar
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ cmp stdout export-one.stdout

# Check that `cue import` supports all filenames too,
# both by default and when loading JSON only.
# TODO(mvdan): note that `cue import --dry-run` does not work,
# so we need to use rm and stderr checks to ensure we create the files we expect.

! exec cue import --list --dry-run .
stderr 'invalid JSON .*input-many.json.* after top-level value'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ cd premodules-downstream-direct
stderr '^no language version declared in module.cue; run ''cue mod fix''$'

# Upstream development works once `cue mod fix` adds a language.version field.
# TODO(mvdan): we don't have anything like `cue mod edit -langversion` if the user wants an older version.
! exec cue mod tidy --check
stderr '^no language version declared in module.cue; run ''cue mod fix''$'
! exec cue mod get some.dependency
Expand Down
2 changes: 0 additions & 2 deletions encoding/toml/decode_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -803,8 +803,6 @@ line two.\

// Ensure that the CUE node can be compiled into a cue.Value and validated.
ctx := cuecontext.New()
// TODO(mvdan): cue.Context can only build ast.Expr or ast.File, not ast.Node;
// it's then likely not the right choice for the interface to return ast.Node.
val := ctx.BuildFile(file)
qt.Assert(t, qt.IsNil(val.Err()))
qt.Assert(t, qt.IsNil(val.Validate()))
Expand Down

0 comments on commit eeec3f5

Please sign in to comment.