Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate GIFs (#314) #315

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Regenerate GIFs (#314) #315

merged 2 commits into from
Dec 8, 2023

Conversation

tyranron
Copy link
Member

@tyranron tyranron commented Dec 8, 2023

Resolves #314

Synopsis

See #314:

Hi, i followed the Quickstart guide and tried to run die example tests. I m on Windows 10
When i call cargo test -p cucumber --test example it fails instantly with:
(error: package cucumber cannot be tested because it requires dev-dependencies and is not a member of the workspace)

I think I should strip that -p cucumber in the Book, because it definitely confuses newbies, not familiar with Rust tooling. Thanks for pointing that out.

Actually, I couldn't find such command anywhere in the Book or in the docs. Could you point where exactly you got it from?

UPD: Oh... it's on the generated images, because they are recorded from running in this repo.

Solution

Regenerate GIF images, so they don't contain -p cucumber part.

@tyranron tyranron added enhancement Improvement of existing features or bugfix k::documentation Related to project documentation labels Dec 8, 2023
@tyranron tyranron added this to the 0.21.0 milestone Dec 8, 2023
@tyranron tyranron self-assigned this Dec 8, 2023
@tyranron
Copy link
Member Author

tyranron commented Dec 8, 2023

CI failure is nightly fluctuation.

@tyranron tyranron merged commit 43ad72c into main Dec 8, 2023
41 of 42 checks passed
@tyranron tyranron deleted the 314-fix-book-commands branch December 11, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::documentation Related to project documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with Cucumber setup
1 participant