Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add syntax highlighting for gherkin inside the book #251

Merged
merged 4 commits into from
Dec 8, 2022
Merged

Add syntax highlighting for gherkin inside the book #251

merged 4 commits into from
Dec 8, 2022

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Dec 8, 2022 •
edited by tyranron
Loading

Synopsis

For now, gherkin is rendered as plaintext inside the book.

Solution

Build our own version of highlight.js with gherkin included.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv added enhancement Improvement of existing features or bugfix k::documentation Related to project documentation labels Dec 8, 2022
@ilslv ilslv added this to the 0.18.1 milestone Dec 8, 2022
@ilslv ilslv self-assigned this Dec 8, 2022
tyranron
tyranron approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilslv thanks! I've added Makefile command for building highlight.js without fuss.

@tyranron tyranron added the k::toolchain Related to project toolchain label Dec 8, 2022
@tyranron tyranron merged commit d473e11 into main Dec 8, 2022
@tyranron tyranron deleted the gherkin-syntax-highlighting branch December 8, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix k::documentation Related to project documentation k::toolchain Related to project toolchain
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ilslv @tyranron