Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clone implementations to all public types, where possible #238

Merged
merged 5 commits into from
Nov 1, 2022

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Oct 31, 2022

Synopsis

Not all types implement Clone. This could be useful, when we need to run cucumber multiple times with slightly changed config for example.

Solution

Add Clone implementations to all public types, where possible.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv added the enhancement Improvement of existing features or bugfix label Oct 31, 2022
@ilslv ilslv added this to the 0.15.3 milestone Oct 31, 2022
@ilslv ilslv self-assigned this Oct 31, 2022
@ilslv
Copy link
Member Author

ilslv commented Oct 31, 2022

FCM

Add `Clone` implementations to all public types, where possible (#238)

@ilslv
Copy link
Member Author

ilslv commented Oct 31, 2022

I'll try to deal with failing skeptic tests in a separate PR. This is a known issue and I experienced it locally for a while. I'll also look into alternatives to skeptic.

@ilslv ilslv requested a review from tyranron October 31, 2022 13:39
@tyranron
Copy link
Member

tyranron commented Nov 1, 2022

@ilslv

I'll also look into alternatives to skeptic.

mdbook test ? We do use it in juniper quite well. However, error reporting is not that nice as in skeptic.

@tyranron tyranron merged commit da1adca into main Nov 1, 2022
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tyranron tyranron deleted the impl-clone branch November 1, 2022 10:04
@ilslv ilslv mentioned this pull request Nov 1, 2022
15 tasks
@tyranron tyranron added the k::api Related to API (application interface) label Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants