Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix @retry, @serial and @allow.skipped tags inheritance #237

Merged
merged 5 commits into from
Oct 25, 2022
Merged

Fix @retry, @serial and @allow.skipped tags inheritance #237

merged 5 commits into from
Oct 25, 2022

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Oct 25, 2022 •
edited by tyranron
Loading

Synopsis

Currently only Scenarios with @retry, @serial and @allow.skipped are affected, tags from Features and Rules aren't propagated.

Solution

Inherit tags, as described in documentation.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv added the enhancement Improvement of existing features or bugfix label Oct 25, 2022
@ilslv ilslv added this to the 0.15.2 milestone Oct 25, 2022
@ilslv ilslv self-assigned this Oct 25, 2022
@ilslv
Copy link
Member Author

ilslv commented Oct 25, 2022 •
edited by tyranron
Loading

FCM

Fix `@retry`, `@serial` and `@allow.skipped` tags semantics inheritance (#237)

@ilslv ilslv requested a review from tyranron October 25, 2022 09:25
tyranron
tyranron reviewed Oct 25, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@ilslv ilslv requested a review from tyranron October 25, 2022 10:38
@tyranron tyranron merged commit 38745f2 into main Oct 25, 2022
@tyranron tyranron deleted the propagate-serial branch October 25, 2022 10:59
@tyranron tyranron added the k::refactor Refactoring, technical debt elimination and other improvements of existing code base label Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base
Projects
None yet
Milestone
0.15.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ilslv @tyranron