Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare CLI options as global #216

Merged

Conversation

theredfish
Copy link
Contributor

@theredfish theredfish commented May 25, 2022

By declaring CLI options global we allow their usage in subcommands
for the custom CLI.

Issue : #215

@tyranron tyranron changed the title Declare cli options as global Declare CLI options as global May 25, 2022
@theredfish theredfish force-pushed the feature/global-options-subcommand branch 2 times, most recently from 31b433d to d6cd68b Compare May 26, 2022 07:53
By declaring CLI options global we allow their usage in subcommands
for the custom CLI.
@theredfish theredfish force-pushed the feature/global-options-subcommand branch from d6cd68b to 9e7f242 Compare May 26, 2022 07:59
@theredfish theredfish marked this pull request as ready for review May 26, 2022 08:06
@tyranron tyranron added the enhancement Improvement of existing features or bugfix label May 26, 2022
@tyranron tyranron added this to the 0.14.0 milestone May 26, 2022
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theredfish thanks! 🍻

I've also added mention in Book and missing CHANGELOG entry.

@tyranron tyranron merged commit 72eff59 into cucumber-rs:main May 26, 2022
@theredfish
Copy link
Contributor Author

Indeed I didn't think about it thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants