Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make runner::Basic execute Scenarios as they are available, not in batches #195

Merged
merged 5 commits into from
Jan 7, 2022
Merged

Make runner::Basic execute Scenarios as they are available, not in batches #195

merged 5 commits into from
Jan 7, 2022

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Jan 7, 2022 •
edited by tyranron
Loading

Synopsis

For now Scenarios are executed in batches, so single long-running Scenario can throttle execution.

Solution

Make runner::Basic execute Scenarios as they are available, not in batches.

cargo test --test wait -- --concurrency=3 time reduced from ~49.5 to ~36.5.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv added the enhancement Improvement of existing features or bugfix label Jan 7, 2022
@ilslv ilslv added this to the 0.11.1 milestone Jan 7, 2022
@ilslv ilslv self-assigned this Jan 7, 2022
@ilslv
Copy link
Member Author

ilslv commented Jan 7, 2022 •
edited by tyranron
Loading

FCM

Optimize `runner::Basic` to not wait the whole batch before executing next `Scenario`s (#195)

@ilslv ilslv requested a review from tyranron January 7, 2022 06:43
@tyranron tyranron merged commit 7da9107 into main Jan 7, 2022
@tyranron tyranron deleted the non-batch-basic-runner branch January 7, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Milestone
0.11.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ilslv @tyranron