Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement writer::Json (#127) #159

Merged
merged 6 commits into from
Nov 15, 2021
Merged

Implement writer::Json (#127) #159

merged 6 commits into from
Nov 15, 2021

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Nov 12, 2021 •
edited by tyranron
Loading

Resolves #127

Synopsis

For now cucumber output can't be parsed by default CI tools.

Solution

Implement writer::Json

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv added the enhancement Improvement of existing features or bugfix label Nov 12, 2021
@ilslv ilslv added this to the 0.11 milestone Nov 12, 2021
@ilslv ilslv self-assigned this Nov 12, 2021
@ilslv
Copy link
Member Author

ilslv commented Nov 15, 2021 •
edited by tyranron
Loading

FCM

Implement outputting in Cucumber JSON format (#159, #127)

- impl `writer::Json` behind `output-json` Cargo feature

@ilslv ilslv marked this pull request as ready for review November 15, 2021 09:09
@ilslv ilslv changed the title Draft: Implement writer::Json (#127) Implement writer::Json (#127) Nov 15, 2021
@ilslv ilslv requested a review from tyranron November 15, 2021 09:09
@tyranron tyranron merged commit ab430cc into main Nov 15, 2021
@tyranron tyranron deleted the 127-json-schema branch November 15, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

Produce output JSON for integration with Cucumber for Jira
2 participants
@ilslv @tyranron