Started working for scenario tests for CuberitePluginChecker #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madmaxoft
reviewed
Oct 26, 2016
|
|
||
|
|
||
| function Initialize(a_Plugin) | ||
| PLUGIN = a_Plugin | ||
| PLUGIN:SetName(g_PluginInfo.Name) | ||
| PLUGIN:SetVersion(g_PluginInfo.Version) |
There was a problem hiding this comment.
I suppose we should make an exception in the Checker to allow this one specific case.
There was a problem hiding this comment.
Yeah, probably, but I was planning on removing it here anyway. I find it to be quite ugly.
There was a problem hiding this comment.
Exception added. But yes, this kind of code is ugly, especially all-caps variable names.
There was a problem hiding this comment.
Should cWorld also be an exception? Technically they can be stored right? Since we do have the cRoot:GetWorld method.
|
Do you mind if I merge this? |
madmaxoft
approved these changes
Jun 8, 2017
|
Sure, go ahead, you're the main WE man, after all :) |
|
Although, I think you should first connect the CIs, test this PR and only merge after success. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR WorldEdit works without any problems in the CuberitePluginChecker.