Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Support Domo data queries #7509

Merged
merged 8 commits into from
Dec 22, 2023
Merged

Conversation

MazterQyou
Copy link
Member

@MazterQyou MazterQyou commented Dec 8, 2023

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR improves compatibility with Domo, list of included changes:

  • Added Mon format string to to_char function
  • Added Utf8 to Interval casting support
  • Added TimestampMillisecond output support
  • Push down DATE function
  • Fix ORDER BY remapping with an expression that is equal to a projection expression with an alias containing uppercase letters
  • Support parsing date with zeroed time as Date32 value

Related tests are included.

@MazterQyou MazterQyou requested review from a team as code owners December 8, 2023 18:25
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (aaa8bfd) 48.03% compared to head (ebccd7a) 72.73%.

Files Patch % Lines
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 0.00% 19 Missing ⚠️
rust/cubesql/cubesql/src/sql/dataframe.rs 0.00% 8 Missing ⚠️
...besql/cubesql/src/compile/rewrite/rules/filters.rs 97.91% 2 Missing ⚠️
rust/cubesql/cubesql/src/compile/mod.rs 99.39% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7509       +/-   ##
===========================================
+ Coverage   48.03%   72.73%   +24.69%     
===========================================
  Files         154      328      +174     
  Lines       20895    56125    +35230     
  Branches     5372     5372               
===========================================
+ Hits        10037    40822    +30785     
- Misses      10118    14563     +4445     
  Partials      740      740               
Flag Coverage Δ
cube-backend 48.03% <ø> (ø)
cubesql 87.38% <89.86%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MazterQyou MazterQyou force-pushed the cubesql/domo-data-queries branch from 4e2bfc0 to 16b097f Compare December 14, 2023 05:09
Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2023 7:31am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2023 7:31am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2023 7:31am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2023 7:31am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2023 7:31am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2023 7:31am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2023 7:31am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2023 7:31am

@MazterQyou MazterQyou force-pushed the cubesql/domo-data-queries branch from 16b097f to 164f5c7 Compare December 19, 2023 14:02
@MazterQyou MazterQyou force-pushed the cubesql/domo-data-queries branch from 164f5c7 to ebccd7a Compare December 22, 2023 07:30
@paveltiunov paveltiunov merged commit 6d644dc into master Dec 22, 2023
59 checks passed
@paveltiunov paveltiunov deleted the cubesql/domo-data-queries branch December 22, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants