Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Avoid constant folding for current_date() function duri… #7498

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Dec 7, 2023

…ng SQL push down

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested a review from a team as a code owner December 7, 2023 05:01
Copy link

vercel bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2023 5:28am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2023 5:28am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2023 5:28am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2023 5:28am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2023 5:28am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2023 5:28am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2023 5:28am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2023 5:28am

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (9f30775) 48.03% compared to head (7f1ab5d) 71.69%.

Files Patch % Lines
...st/cubesql/cubesql/src/compile/rewrite/analysis.rs 78.94% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7498       +/-   ##
===========================================
+ Coverage   48.03%   71.69%   +23.65%     
===========================================
  Files         154      328      +174     
  Lines       20872    54692    +33820     
  Branches     5369     5378        +9     
===========================================
+ Hits        10026    39209    +29183     
- Misses      10105    14742     +4637     
  Partials      741      741               
Flag Coverage Δ
cube-backend 48.03% <ø> (ø)
cubesql 86.28% <96.22%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltiunov paveltiunov merged commit e86f4be into master Dec 7, 2023
41 of 43 checks passed
@paveltiunov paveltiunov deleted the custom-date-diff branch December 7, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant