Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubestore-driver): Queue - protect possible race condition with … #7467

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

ovr
Copy link
Member

@ovr ovr commented Nov 28, 2023

Hello!

Thanks

@ovr ovr requested a review from a team as a code owner November 28, 2023 11:09
Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-react-d3 ⬜️ Ignored (Inspect) Nov 28, 2023 11:09am
examples-react-dashboard ⬜️ Ignored (Inspect) Nov 28, 2023 11:09am
examples-react-data-table ⬜️ Ignored (Inspect) Nov 28, 2023 11:09am
examples-react-highcharts ⬜️ Ignored (Inspect) Nov 28, 2023 11:09am
examples-react-pivot-table ⬜️ Ignored (Inspect) Nov 28, 2023 11:09am
examples-vue-query-builder ⬜️ Ignored (Inspect) Nov 28, 2023 11:09am

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4a08de5) 71.57% compared to head (6ee7349) 47.76%.
Report is 1 commits behind head on master.

Files Patch % Lines
...-query-orchestrator/src/orchestrator/QueryQueue.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7467       +/-   ##
===========================================
- Coverage   71.57%   47.76%   -23.82%     
===========================================
  Files         329      155      -174     
  Lines       54525    20852    -33673     
  Branches     5369     5369               
===========================================
- Hits        39028     9960    -29068     
+ Misses      14746    10141     -4605     
  Partials      751      751               
Flag Coverage Δ
cube-backend 47.76% <66.66%> (-0.03%) ⬇️
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovr ovr merged commit 9c0ad07 into master Nov 28, 2023
37 of 39 checks passed
@ovr ovr deleted the fix/queue-race-condition-cancelation-heartbeat branch November 28, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant