-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for basic file filtering when adding an explicit file #44
base: master
Are you sure you want to change the base?
Conversation
…lugin) when adding an explicit file
Sorry that this one has slipped my attention! I don't really understand the reason for this PR though. Couldn't you simply use the maven filtering and then scoop the files with the RPM plugin? |
No worries, we're all busy. ;-) |
So why don't you just use https://maven.apache.org/plugins/maven-resources-plugin/copy-resources-mojo.html instead? I am not really fond of adding another dependency. Having a re-implementation of the filtering is also not really what I would like to see. I am also not sure about the license of that library. The source code says GPL, the project license APLv2. |
Most of my projects are GPLv3, hence I set up my IDE to automatically add the GPL preamble. I've fixed this. Thanks for pointing this out! |
BeanUtils
,FilterUtils
classes stem from that project)<filterFile>true</filterFile>
tag${varname}
variables with the actual valuesproject.name
(seesrc/site/markdown/entry.md
)