Mirror Plugin Chart: Add optional scratch pvc for downloads

[ikaneshiro]

Summary by CodeRabbit

• New Features
  • Conditional mounting of a "scratch" volume at "/scratch" path if scratch persistence is enabled.

[coderabbitai]

Walkthrough

This update introduces a conditional feature within the Helm chart for the beskar-mirror project, enabling users to mount a "scratch" volume at the /scratch path, provided that the scratch persistence setting is activated. This enhancement caters to scenarios requiring temporary data storage during the application's runtime.

Changes

File Path	Change Summary
charts/beskar-mirror/.../_helpers.tpl	Added a conditional block for mounting "scratch" volume at /scratch if scratch persistence is enabled.

🐇✨
In the realm of code, a change was made,
A scratch space for data, not to fade.
At /scratch it lies, a hidden glade,
Where bytes can dance, and memories parade.
🎉Celebrate, for persistence we've swayed!
🐾- CodeRabbit

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 5980744 and ac28397.

Files ignored due to path filters (2)

• charts/beskar-mirror/templates/statefulset.yaml is excluded by: !**/*.yaml
• charts/beskar-mirror/values.yaml is excluded by: !**/*.yaml

Files selected for processing (1)

• charts/beskar-mirror/templates/_helpers.tpl (1 hunks)

Additional comments: 1

charts/beskar-mirror/templates/_helpers.tpl (1)

• 122-125: The addition of the conditional block for mounting a scratch volume is well-implemented. It correctly checks if the scratch persistence is enabled before adding the volume mount. This aligns with the PR's objective of making the scratch PVC optional. However, it's important to ensure that the corresponding volume definition for "scratch" is also conditionally created in the volumes section to avoid potential issues with undefined volumes.

Ensure that the scratch volume is conditionally defined in the volumes section to match this conditional mount. This is crucial for maintaining consistency and avoiding runtime errors due to referencing an undefined volume.