added unit test for input commands. Now handles wrong sub command pro…

…perly

configuration/commands.go

@@ -3,17 +3,20 @@
 
 package configuration
 
-import "os"
+import (
+	"errors"
+	"os"
+)
 
 type Command struct {
-	Install bool
-	Remove  bool
-	Start   bool
-	Stop    bool
-	Status  bool
+	Install 	bool
+	Remove  	bool
+	Start   	bool
+	Stop    	bool
+	Status  	bool
 }
 
-func (cmd *Command) MakeCmd() {
+func (cmd *Command) MakeCmd() error {
 
 	if len(os.Args) > 1 {
 		cmds := os.Args[1]
@@ -28,7 +31,10 @@ func (cmd *Command) MakeCmd() {
 			cmd.Stop = true
 		case "status":
 			cmd.Status = true
+		default:
+			return errors.New("invalid command: " + cmds)
 		}
 	}
 
+	return nil
 }

configuration/commands_test.go

@@ -0,0 +1,58 @@
+// Craig Tomkow
+// August 15, 2019
+
+package configuration
+
+import (
+	"os"
+	"testing"
+)
+
+var argTests = []struct {
+	input		string
+	expected	bool
+}{
+	{"install", true},
+	{"remove", true},
+	{"start", true},
+	{"stop", true},
+	{"status", true},
+}
+
+func TestCommand_MakeCmd(t *testing.T) {
+
+	cmd := new(Command)
+
+	for _, argTest := range argTests {
+		os.Args = []string{"tto", argTest.input}
+		err := cmd.MakeCmd()
+
+		switch argTest.input {
+		case "install":
+			if argTest.expected != cmd.Install {
+				t.Errorf("Input arg test failed; found, expected: %t, %t", cmd.Install, argTest.expected)
+			}
+		case "remove":
+			if argTest.expected != cmd.Remove {
+				t.Errorf("Input arg test failed; found, expected: %t, %t", cmd.Remove, argTest.expected)
+			}
+		case "start":
+			if argTest.expected != cmd.Start {
+				t.Errorf("Input arg test failed; found, expected: %t, %t", cmd.Start, argTest.expected)
+			}
+		case "stop":
+			if argTest.expected != cmd.Stop {
+				t.Errorf("Input arg test failed; found, expected: %t, %t", cmd.Stop, argTest.expected)
+			}
+		case "status":
+			if argTest.expected != cmd.Status {
+				t.Errorf("Input arg test failed; found, expected: %t, %t", cmd.Status, argTest.expected)
+			}
+		default:
+			if err == nil {
+				t.Errorf("Input arg test failed; found, expected: %t, %t", cmd.Status, argTest.expected)
+			}
+		}
+
+	}
+}

tto.go

@@ -25,7 +25,9 @@ func main() {
 	configFile := configuration.CliFlags()
 
 	var cmd = new(configuration.Command)
-	cmd.MakeCmd()
+	if err := cmd.MakeCmd(); err != nil {
+		glog.Fatal(err)
+	}
 
 	if cmd.Install {
 		install()
@@ -50,7 +52,7 @@ func main() {
 
 func (srv *Service) Manage(cmd *configuration.Command, configFile *string) (string, error) {
 
-	usage := "Usage: tto install | remove | start | stop | status"
+	usage := "usage: tto install | remove | start | stop | status"
 
 	if cmd.Install {
 		return srv.Install()