add class to compute statistics on the fly #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #75 +/- ##
=========================================
+ Coverage 3.08% 5.61% +2.53%
=========================================
Files 36 37 +1
Lines 3571 3667 +96
=========================================
+ Hits 110 206 +96
Misses 3461 3461
☔ View full report in Codecov by Sentry. |
jlenain
reviewed
Sep 12, 2023
There was a problem hiding this comment.
Hi @vmarandon ,
Thanks a lot for this! I have one nitpicking request: instead of hardcoding the expected signal shape (number of channels, pixels, time stamps), I would suggest to rely on a single place for it, through ctapipe_io_nectarcam (I use to make the same comment in past PRs).
…ples) to use the one from ctapipe_io_nectarcam.constants.py
jlenain
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class to compute statistics on the fly using the Welford's algorithm (mean, variance, min, max).