Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added final test (final version of user script before I leave) #158

Merged
merged 20 commits into from
Nov 6, 2024

Conversation

dmousadi
Copy link
Contributor

@dmousadi dmousadi commented Oct 25, 2024

Hi, sorry for the consecutive pull request, but today is my last day at CEA and I thought I should add the final version of the tests. I have added the test for the trigger timing requirement and made some changes to the gui. If there is anything that I need to change, please let me know.

@jlenain
Copy link
Collaborator

jlenain commented Nov 6, 2024

Hi @dmousadi ,

Thank you very much for this. At the moment, this PR has conflicts with our main branch, and I am in no position to judge which should take precedence. Could you please fix these ?

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.51%. Comparing base (b306f30) to head (ce13435).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
+ Coverage   40.76%   47.51%   +6.74%     
==========================================
  Files          65       64       -1     
  Lines        4452     4590     +138     
==========================================
+ Hits         1815     2181     +366     
+ Misses       2637     2409     -228     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmousadi
Copy link
Contributor Author

dmousadi commented Nov 6, 2024

Hi, I resolved the conflicts, the correct ones were the newer versions of the files.
Sorry for the multiple commits, but it wasn't passing the hooks because of some spaces and I was trying to fix it via online editor to save time, because I haven't installed nectarchain on the computer I am currently using.
Let me know if I need to change something else!

@jlenain
Copy link
Collaborator

jlenain commented Nov 6, 2024

Thanks a lot, @dmousadi !

@jlenain jlenain merged commit 8a02577 into cta-observatory:main Nov 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants