-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added final test (final version of user script before I leave) #158
Conversation
Merge branch 'main' of https://github.com/dmousadi/nectarchain
Hi @dmousadi , Thank you very much for this. At the moment, this PR has conflicts with our |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
+ Coverage 40.76% 47.51% +6.74%
==========================================
Files 65 64 -1
Lines 4452 4590 +138
==========================================
+ Hits 1815 2181 +366
+ Misses 2637 2409 -228 ☔ View full report in Codecov by Sentry. |
Hi, I resolved the conflicts, the correct ones were the newer versions of the files. |
Thanks a lot, @dmousadi ! |
Hi, sorry for the consecutive pull request, but today is my last day at CEA and I thought I should add the final version of the tests. I have added the test for the trigger timing requirement and made some changes to the gui. If there is anything that I need to change, please let me know.