-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRR tools in user scripts #155
Conversation
src/nectarchain/user_scripts/dmousadi/test_scripts/requirements.txt
Outdated
Show resolved
Hide resolved
src/nectarchain/user_scripts/dmousadi/test_scripts/tests/utils.py
Outdated
Show resolved
Hide resolved
src/nectarchain/user_scripts/dmousadi/test_scripts/tests/utils.py
Outdated
Show resolved
Hide resolved
src/nectarchain/user_scripts/dmousadi/test_scripts/tests/utils.py
Outdated
Show resolved
Hide resolved
src/nectarchain/user_scripts/dmousadi/test_scripts/tests/utils.py
Outdated
Show resolved
Hide resolved
Could you please lint the code using our |
Done! Let me know if there is more I need to change or if I did something wrong. |
Hi @dmousadi , Also, I do not understand why #155 (comment) is marked as solved. Thanks! |
Hi! Sorry, I thought I deleted that before. I was not familiar with pre-commit but I think it's fine now? Let me know if I have to change something now. |
Hi @dmousadi ! |
OK, the linting part passes, but not |
See #156 |
Okay, I added you as a collaborator |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
+ Coverage 40.76% 49.00% +8.23%
==========================================
Files 65 64 -1
Lines 4452 4561 +109
==========================================
+ Hits 1815 2235 +420
+ Misses 2637 2326 -311 ☔ View full report in Codecov by Sentry. |
Added the directory with the camera test scripts for the TRR. Ignore the first two commits (accidentally added it as submodule). There is a readme file that explains how the tests work.