Add checks for observability and grid plot #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HealthyPear
force-pushed
the
plots-observation_grid
branch
from
f079573 to
b1a066f
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
HealthyPear
force-pushed
the
plots-observation_grid
branch
3 times, most recently
from
6b2bcbc to
5caccd8
Compare
aleberti
suggested changes
Nov 14, 2024
|
I tried the example notebook for a few different settings, to check that e.g. for the Crab I get 0 hours if I put a very limited zenith range below its culmination zenith. As additional comments:
|
Fix bug in observability module fix formatting issue when definining AtNightConstraint
Update call to check_observability Fix call to observation datetime from main.py Update call to source_detection in main.py
to account for leap years in functions which depend on year length
- add observability heatmap - fixed docstrings - improved label appearance in observability grid
- call observability heatmap - call observability grid only if within a day
HealthyPear
force-pushed
the
plots-observation_grid
branch
from
5caccd8 to
754b6cf
Compare
done
done Thanks! Let me know if there is something else missing or not working! |
|
This PR also closes #9 unless something else comes up before final approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16 .
Also adds preliminary checks if the source is ever observable and which months are best to observe it.
Also adds plots like these
this one only if selected time range is not more than 1 day