ctapipe v0.15 #153
ctapipe v0.15 #153
Conversation
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
=======================================
Coverage 86.80% 86.80%
=======================================
Files 17 17
Lines 1728 1728
=======================================
Hits 1500 1500
Misses 228 228 Continue to review full report at Codecov.
|
| @@ -3,8 +3,8 @@ channels: | |||
| - conda-forge | |||
| - default | |||
| dependencies: | |||
| - astropy>=4.2 | |||
| - python=3.8 # nail the python version, so conda does not try upgrading / dowgrading | |||
There was a problem hiding this comment.
That = and comment is really important and must not be changed.
Isn't the comment clear enough?
There was a problem hiding this comment.
It does not say why python=3.8 is mandatory - and since the tests are passing with more recent versions, it was not clear to me why we should pin it.
There was a problem hiding this comment.
It needs to be pinned to some version. Not to 3.8 specifically. But the sed command in the CI config uses the python= to insert the version used for the tests:
ctapipe_io_lst/.github/workflows/ci.yml
Line 27 in afac9ce
There was a problem hiding this comment.
So if you want to change the default version, all good, but it should still be a fixed version.
|
Closing in favor of #161 |
No description provided.