Use .key instead of .keyCode / .charCodefor keyboard events

csweichel · Aug 26, 2022 · ab175e2 · ab175e2
1 parent da8909e
commit ab175e2
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/pkg/webui/src/JobList.tsx b/pkg/webui/src/JobList.tsx
@@ -300,8 +300,8 @@ class JobListImpl extends React.Component<JobListProps, JobListState> {
     }
 
     protected handleSearchKeyPress(evt: KeyboardEvent) {
-        if (evt.charCode !== 13) {
-            return
+        if (evt.key !== "Enter") {
+            return;
         }
 
         window.location.href = "/jobs/" + (evt.target as HTMLInputElement).value;

diff --git a/pkg/webui/src/JobView.tsx b/pkg/webui/src/JobView.tsx
@@ -498,8 +498,8 @@ class JobViewImpl extends React.Component<JobViewProps, JobViewState> {
 }
 
 function returnToJobList(this: Window, evt: KeyboardEvent): any {
-    if (evt.keyCode !== 27) {
-        return
+    if (evt.key !== "Escape") {
+        return;
     }
 
     evt.preventDefault();

diff --git a/pkg/webui/src/StartJob.tsx b/pkg/webui/src/StartJob.tsx
@@ -219,8 +219,8 @@ class StartJobImpl extends React.Component<StartJobProps, StartJobState> {
     }
 
     protected handleSearchKeyPress(evt: KeyboardEvent) {
-        if (evt.charCode !== 13) {
-            return
+        if (evt.key !== "Enter") {
+            return;
         }
 
         window.location.href = "/jobs/" + (evt.target as HTMLInputElement).value;