[cron] fixed a race

Fixes #107
csweichel · Nov 26, 2021 · 3b61d0a · 3b61d0a
1 parent 0e49c88
commit 3b61d0a
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/plugins/cron/main.go b/plugins/cron/main.go
@@ -60,16 +60,17 @@ func (*cronPlugin) Run(ctx context.Context, config interface{}, srv v1.WerftServ
 			})
 		}
 
+		request := &v1.StartGitHubJobRequest{
+			Metadata: &v1.JobMetadata{
+				Owner:       "cron",
+				Annotations: annotations,
+				Trigger:     trigger,
+				Repository:  repo,
+			},
+			JobPath: task.JobPath,
+		}
 		_, err = c.AddFunc(task.Spec, func() {
-			_, err := srv.StartGitHubJob(ctx, &v1.StartGitHubJobRequest{
-				Metadata: &v1.JobMetadata{
-					Owner:       "cron",
-					Annotations: annotations,
-					Trigger:     trigger,
-					Repository:  repo,
-				},
-				JobPath: task.JobPath,
-			})
+			_, err := srv.StartGitHubJob(ctx, request)
 			if err != nil {
 				log.WithError(err).WithField("idx", idx).WithField("spec", task.Spec).Error("cannot start job")
 			}