Fix Cross Browser Permissions (#20)

* Fix Cross Browser Permissions * Update README.md
cssnr · May 19, 2024 · da73051 · da73051
1 parent d71d1ea
commit da73051
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -51,10 +51,11 @@ All **Chromium** Based Browsers can install the extension from the
 *   Easily Play Narrative as Text to Speech
 *   Search Registration/Operator from Selection Text
 *   Search Registration/Operator from Popup Action
+*   Auto Fill New Incidents for US and Canada Registration
 
 ### Upcoming Features and Ideas
 
-*   Auto Fill for New Event Submissions
+*   Infinite Scroll when Browsing Incidents
 
 > [!TIP]
 > **Don't see your feature here?**

diff --git a/manifest-chrome.json b/manifest-chrome.json
@@ -1,4 +1,8 @@
 {
+  "optional_host_permissions": [
+    "*://registry.faa.gov/AircraftInquiry/Search/*",
+    "*://wwwapps.tc.gc.ca/saf-sec-sur/2/ccarcs-riacc/*"
+  ],
   "background": {
     "service_worker": "js/service-worker.js"
   },

diff --git a/manifest-firefox.json b/manifest-firefox.json
@@ -1,4 +1,8 @@
 {
+  "optional_permissions": [
+    "*://registry.faa.gov/AircraftInquiry/Search/*",
+    "*://wwwapps.tc.gc.ca/saf-sec-sur/2/ccarcs-riacc/*"
+  ],
   "background": {
     "scripts": ["js/service-worker.js"]
   },

diff --git a/manifest.json b/manifest.json
@@ -24,10 +24,6 @@
   },
   "permissions": ["contextMenus", "scripting", "storage"],
   "host_permissions": ["*://*.aviation-safety.net/*"],
-  "optional_permissions": [
-    "*://registry.faa.gov/AircraftInquiry/Search/*",
-    "*://wwwapps.tc.gc.ca/saf-sec-sur/2/ccarcs-riacc/*"
-  ],
   "content_scripts": [
     {
       "matches": ["*://*.aviation-safety.net/*"],

diff --git a/src/js/asn.js b/src/js/asn.js
@@ -376,7 +376,7 @@ async function enableAUtoFill(options) {
     const extraPerms = await chrome.runtime.sendMessage('extraPerms')
     console.log('extraPerms', extraPerms)
     if (!extraPerms) {
-        console.warn('MISSING EXTRA PERMISSIONS')
+        console.debug('Missing Extra Permissions')
 
         const p = document.createElement('p')
         p.textContent =

diff --git a/src/js/export.js b/src/js/export.js
@@ -60,6 +60,9 @@ export async function checkPerms() {
 
 function updatePermsEl(hasPerms, has, grant) {
     console.debug('updatePermsEl:', hasPerms, has, grant)
+    if (typeof document === 'undefined') {
+        return console.debug('document undefined')
+    }
     const hasEl = document.querySelectorAll(has)
     const grantEl = document.querySelectorAll(grant)
     if (hasPerms) {