Ensure - is not used as an identifier

`-` is not a valid identifier, so it must be either escaped as `\-` or used as a string (i.e. wrapped in quotes). Ref. c5095eb. Ref. #73.
css · Jan 14, 2016 · f4e9244 · f4e9244
1 parent 42582aa
commit f4e9244
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 3 deletions.
diff --git a/lib/compressor/compress/Attribute.js b/lib/compressor/compress/Attribute.js
@@ -5,7 +5,7 @@ var escapesRx = /\\([0-9A-Fa-f]{1,6})[ \t\n\f\r]?|\\./g;
 var blockUnquoteRx = /^(-?\d|--)|[\u0000-\u002c\u002e\u002f\u003A-\u0040\u005B-\u005E\u0060\u007B-\u009f]/;
 
 function canUnquote(value) {
-    if (!value) {
+    if (value === '' || value === '-') {
         return;
     }
 

diff --git a/test/fixture/compress/attrib.string/1.css b/test/fixture/compress/attrib.string/1.css
@@ -1,6 +1,7 @@
 [title="test"],
 [title="123"],
 [title="test test"],
+[title="-"],
 [title=""]
 {
     p: v;

diff --git a/test/fixture/compress/attrib.string/1.min.css b/test/fixture/compress/attrib.string/1.min.css
@@ -1 +1 @@
-[title=""],[title="123"],[title="test test"],[title=test]{p:v}
+[title=""],[title="-"],[title="123"],[title="test test"],[title=test]{p:v}
diff --git a/test/fixture/compress/attrib.string/2.css b/test/fixture/compress/attrib.string/2.css
@@ -1,6 +1,7 @@
 [title='test'],
 [title='123'],
 [title='test test'],
+[title='-'],
 [title='']
 {
     p: v;

diff --git a/test/fixture/compress/attrib.string/2.min.css b/test/fixture/compress/attrib.string/2.min.css
@@ -1 +1 @@
-[title=''],[title='123'],[title='test test'],[title=test]{p:v}
+[title=''],[title='-'],[title='123'],[title='test test'],[title=test]{p:v}
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		[title=""],[title="123"],[title="test test"],[title=test]{p:v}
		[title=""],[title="-"],[title="123"],[title="test test"],[title=test]{p:v}
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		[title=''],[title='123'],[title='test test'],[title=test]{p:v}
		[title=''],[title='-'],[title='123'],[title='test test'],[title=test]{p:v}