don't compress values and zero length dimensions outside declaration

css · Feb 28, 2016 · d75201c · d75201c
1 parent bfac3b2
commit d75201c
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/lib/compressor/compress/Dimension.js b/lib/compressor/compress/Dimension.js
@@ -19,9 +19,9 @@ module.exports = function compressDimension(node, item) {
 
     node.value = value;
 
-    if (value === '0' && !NON_LENGTH_UNIT.hasOwnProperty(unit)) {
+    if (value === '0' && this.declaration && !NON_LENGTH_UNIT.hasOwnProperty(unit)) {
         // issue #200: don't remove units in flex property as it could change value meaning
-        if (this.declaration && this.declaration.property.name === 'flex') {
+        if (this.declaration.property.name === 'flex') {
             return;
         }
 

diff --git a/lib/compressor/compress/Value.js b/lib/compressor/compress/Value.js
@@ -3,6 +3,10 @@ var compressFontWeight = require('./property/font-weight.js');
 var compressBackground = require('./property/background.js');
 
 module.exports = function compressValue(node) {
+    if (!this.declaration) {
+        return;
+    }
+
     var property = this.declaration.property.name;
 
     if (/background$/.test(property)) {

diff --git a/test/fixture/compress/atrules/supports-2.css b/test/fixture/compress/atrules/supports-2.css
@@ -1,5 +1,5 @@
 /*
-    issue #273 should compress length dimension outside block
+    issue #273 shouldn't compress length dimension outside declaration
 */
 @supports (width: 0px) and (test: 0deg) {
     .test {

diff --git a/test/fixture/compress/atrules/supports-2.min.css b/test/fixture/compress/atrules/supports-2.min.css
@@ -1 +1 @@
-@supports (width:0) and (test:0deg){.test{foo:1}}
+@supports (width:0px) and (test:0deg){.test{foo:1}}
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		@supports (width:0) and (test:0deg){.test{foo:1}}
		@supports (width:0px) and (test:0deg){.test{foo:1}}