-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use kairos-tx
for L1 deposit transactions
#88
Draft
koxu1996
wants to merge
21
commits into
main
Choose a base branch
from
feature/use-kairos-tx-in-contract
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marijanp
force-pushed
the
feature/deposit-contract
branch
from
May 14, 2024 21:52
947e278
to
40822ed
Compare
Merged
This finally fixes `no_std` compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes changes to the smart contract to incorporate a full transaction format for L1 deposit events, aiming to standardize them with L2 transactions.
Rationale
Proposed Changes
Modify the smart contract so that users making L1 deposits will be required to provide "deposit transaction" data matching the L2 format through a smart contract entry point. This data must align with the amount of tokens transferred and the identity of the transaction caller, ensuring consistency and integrity between L1 deposits and the L2 transaction format.
NOTE: Build is currently failing because of
kairos-l1-utils
introduced infeature/deposit-contract
.Discussion Points
Feedback and Future Discussion
This PR is tagged with "needs-discussion" to engage the team in evaluating the benefits and implications of integrating a unified transaction format. Feedback and discussions on this proposal are expected to occur after the MVP phase, as it is not an immediate requirement for the initial launch.
Future work
kairos_crypto
compatibility withno_std
-kairos-crypto
- split trait and introduceno_std
support #123.kairos_tx
compatibility withno_std
- Userasn
fork that is fully compatible with no-std #126.