Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no_std support to kairos-tx #61

Merged
merged 8 commits into from
Apr 4, 2024
Merged

Conversation

koxu1996
Copy link
Contributor

@koxu1996 koxu1996 commented Apr 3, 2024

This PR adds support for no_std in kairos-tx 🚀.

Note: I replaced thiserror with plain enum implementing fmt::Display, as advised by @Avi-D-coder 👏.

Closes #60.

@koxu1996 koxu1996 self-assigned this Apr 3, 2024
@Avi-D-coder
Copy link
Contributor

It would be nice to have a github action to build this with --no-default-features

@koxu1996
Copy link
Contributor Author

koxu1996 commented Apr 3, 2024

@Avi-D-coder, do you want to build it with no_std and store the artifact, or you just want to see if it builds correctly?

@Avi-D-coder
Copy link
Contributor

Just see if it builds correctly.

Copy link

github-actions bot commented Apr 3, 2024

File Coverage
All files 61%
kairos-server/tests/transactions.rs 83%
kairos-test-utils/src/cctl/parsers.rs 66%
kairos-crypto/src/implementations/casper.rs 3%
kairos-server/src/routes/deposit.rs 86%
kairos-server/src/routes/transfer.rs 73%
kairos-server/src/routes/withdraw.rs 91%
kairos-test-utils/src/cctl.rs 87%
kairos-tx/src/asn.rs 77%
kairos-tx/src/error.rs 0%
kairos-server/src/config.rs 0%
kairos-server/src/errors.rs 16%
kairos-server/src/utils.rs 22%

Minimum allowed coverage is 60%

Generated by 🐒 cobertura-action against fe85305

@koxu1996
Copy link
Contributor Author

koxu1996 commented Apr 3, 2024

@Avi-D-coder I added extra CI check - it passed successfully:

image

I guess we need something similar for kairos-trie.

@Avi-D-coder
Copy link
Contributor

Yeah added it now

@Avi-D-coder
Copy link
Contributor

ignore the hercules failures they are unrelated.

Copy link
Contributor

@Avi-D-coder Avi-D-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koxu1996 koxu1996 merged commit 9f11f30 into main Apr 4, 2024
8 checks passed
@koxu1996 koxu1996 deleted the feature/make-kairos-tx-no-std branch April 4, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for no_std in kairos-tx
3 participants