Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust version, cargo packages, flake inputs, except risc0 #36

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

Avi-D-coder
Copy link
Contributor

No description provided.

Copy link
Contributor

@koxu1996 koxu1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Avi-D-coder
Copy link
Contributor Author

ah, the signed commit check does not appear to consider actions taken by the github web ui verified. I’ll have to rebase locally tomorrow.

@marijanp
Copy link
Contributor

@Avi-D-coder seems like your git is not configured properly. The signatures are still missing.

@Avi-D-coder
Copy link
Contributor Author

@Avi-D-coder seems like your git is not configured properly. The signatures are still missing.

I signed on the cli, that worked, and was passing the check.
I then used Github's web UI to rebase, and that removed the signatures.
Is there a way to get the check to recognize commit's from Github web ui as verified?

@Avi-D-coder
Copy link
Contributor Author

@Avi-D-coder seems like your git is not configured properly. The signatures are still missing.

I signed on the cli, that worked, and was passing the check. I then used Github's web UI to rebase, and that removed the signatures. Is there a way to get the check to recognize commit's from Github web ui as verified?

I guess not, that sucks.
https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#signature-verification-for-rebase-and-merge

@marijanp
Copy link
Contributor

Yeah I assumed that it is not able to use your keys. And probably better like that, you don't want to upload them to GitHub

@Avi-D-coder Avi-D-coder merged commit 2fe12fc into main Mar 18, 2024
6 checks passed
@Avi-D-coder Avi-D-coder deleted the update-rust branch March 18, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants