Debug cctl batch failing (Ready to merge) #177

Avi-D-coder · 2024-07-31T00:12:34Z

This PR shows that the same exact proof testdata/proof-from-server.json works as expected in the test execution engine, but fails under cctl with Interpreter error: trap: Code(Unreachable)

This also upgrades risc0, and improves error handling, ~~once verify under cctl is work we can fixup the pr to remove debug logic~~ done.

…ronment

Avi-D-coder · 2024-07-31T00:49:11Z

Ok it's working against cctl now.

kairos on  debug-cctl-batch-failing [$!] is 📦 v0.1.0 via 🦀 v1.79.0 via ❄️  impure (nix-shell-env) 
❯ cargo run --release --bin kairos-server --no-default-features
warning: /Users/avi/Code/Casper/kairos/kairos-cli/Cargo.toml: unused manifest key: bin.0.version
warning: /Users/avi/Code/Casper/kairos/kairos-contracts/demo-contract/contract-utils/Cargo.toml: `default-features` is ignored for casper-event-standard, since `default-features` was not specified for `workspace.dependencies.casper-event-standard`, this could become a hard error in the future
warning: /Users/avi/Code/Casper/kairos/Cargo.toml: unused manifest key: workspace.package.name
warning: /Users/avi/Code/Casper/kairos/kairos-test-utils/Cargo.toml: unused manifest key: bin.0.version
    Finished `release` profile [optimized] target(s) in 0.21s
     Running `target/release/kairos-server`
2024-07-31T00:41:27.772127Z  INFO kairos_server: listening on `0.0.0.0:9999`
2024-07-31T00:41:27.772599Z  INFO kairos_server::l1_sync::event_manager: Initializing event manager
2024-07-31T00:41:27.782755Z  INFO kairos_server::l1_sync::event_manager: Looking for new events
2024-07-31T00:41:37.783776Z  INFO kairos_server::l1_sync::event_manager: Looking for new events
2024-07-31T00:41:37.787656Z  INFO kairos_server::state::transactions::batch_state: Executing deposit: L1Deposit { recipient: [1, 175, 121, 242, 139, 222, 69, 34, 178, 126, 219, 141, 201, 223, 20, 108, 157, 58, 101, 249, 68, 187, 220, 241, 83, 234, 16, 123, 41, 27, 174, 35, 45], amount: 500 }
2024-07-31T00:41:47.784036Z  INFO kairos_server::l1_sync::event_manager: Looking for new events
2024-07-31T00:41:47.787780Z  INFO kairos_server::state::transactions::batch_state: Executing deposit: L1Deposit { recipient: [1, 175, 121, 242, 139, 222, 69, 34, 178, 126, 219, 141, 201, 223, 20, 108, 157, 58, 101, 249, 68, 187, 220, 241, 83, 234, 16, 123, 41, 27, 174, 35, 45], amount: 500 }
2024-07-31T00:41:47.787997Z  INFO kairos_server::state: Sending batch output to proving server: [Deposit(L1Deposit { recipient: [1, 175, 121, 242, 139, 222, 69, 34, 178, 126, 219, 141, 201, 223, 20, 108, 157, 58, 101, 249, 68, 187, 220, 241, 83, 234, 16, 123, 41, 27, 174, 35, 45], amount: 500 }), Deposit(L1Deposit { recipient: [1, 175, 121, 242, 139, 222, 69, 34, 178, 126, 219, 141, 201, 223, 20, 108, 157, 58, 101, 249, 68, 187, 220, 241, 83, 234, 16, 123, 41, 27, 174, 35, 45], amount: 500 })]
2024-07-31T00:41:48.848780Z  INFO kairos_server::state: Proving server returned success
2024-07-31T00:41:48.850268Z  INFO kairos_server::state::submit_batch: Submitting proof to contract: ContractHash(1689e4f3b82bcdc7fdaf7253738bb58297ca8dfc6aa9741ec7468a943c8a681a)
2024-07-31T00:41:57.784246Z  INFO kairos_server::l1_sync::event_manager: Looking for new events
2024-07-31T00:41:59.895322Z  INFO kairos_server::state::submit_batch: Deploy successful: SuccessResponse { jsonrpc: "2.0", id: Number(8396921001411452868), result: PutDeployResult { api_version: ProtocolVersion(SemVer { major: 1, minor: 0, patch: 0 }), deploy_hash: DeployHash(1c3e753408b9d0898ea3904ac4eed124c480867790e664b79606a7ccdc9de0a8) } }
2024-07-31T00:42:07.783945Z  INFO kairos_server::l1_sync::event_manager: Looking for new events
2024-07-31T00:42:17.784337Z  INFO kairos_server::l1_sync::event_manager: Looking for new events
2024-07-31T00:42:27.783720Z  INFO kairos_server::l1_sync::event_manager: Looking for new events
2024-07-31T00:42:37.784136Z  INFO kairos_server::l1_sync::event_manager: Looking for new events
2024-07-31T00:42:47.783615Z  INFO kairos_server::l1_sync::event_manager: Looking for new events
2024-07-31T00:42:57.783104Z  INFO kairos_server::l1_sync::event_manager: Looking for new events
2024-07-31T00:43:07.783500Z  INFO kairos_server::l1_sync::event_manager: Looking for new events
2024-07-31T00:43:17.783821Z  INFO kairos_server::l1_sync::event_manager: Looking for new events
2024-07-31T00:43:27.784295Z  INFO kairos_server::l1_sync::event_manager: Looking for new events
2024-07-31T00:43:37.784184Z  INFO kairos_server::l1_sync::event_manager: Looking for new events
2024-07-31T00:43:44.346166Z  INFO kairos_server::routes::withdraw: parsing transaction data
2024-07-31T00:43:44.346220Z  INFO kairos_server::routes::withdraw: queuing withdrawal transaction
2024-07-31T00:43:44.346242Z  INFO kairos_server::state::transactions::batch_state: Executing withdraw: Signed { public_key: [1, 175, 121, 242, 139, 222, 69, 34, 178, 126, 219, 141, 201, 223, 20, 108, 157, 58, 101, 249, 68, 187, 220, 241, 83, 234, 16, 123, 41, 27, 174, 35, 45], nonce: 0, transaction: Withdraw { amount: 500 } }
2024-07-31T00:43:44.346293Z  INFO kairos_server::state: Sending batch output to proving server: [Withdraw(Signed { public_key: [1, 175, 121, 242, 139, 222, 69, 34, 178, 126, 219, 141, 201, 223, 20, 108, 157, 58, 101, 249, 68, 187, 220, 241, 83, 234, 16, 123, 41, 27, 174, 35, 45], nonce: 0, transaction: Withdraw { amount: 500 } })]
2024-07-31T00:43:45.365829Z  INFO kairos_server::state: Proving server returned success
2024-07-31T00:43:45.367180Z  INFO kairos_server::state::submit_batch: Submitting proof to contract: ContractHash(1689e4f3b82bcdc7fdaf7253738bb58297ca8dfc6aa9741ec7468a943c8a681a)
2024-07-31T00:43:47.783988Z  INFO kairos_server::l1_sync::event_manager: Looking for new events
2024-07-31T00:43:56.169767Z  INFO kairos_server::state::submit_batch: Deploy successful: SuccessResponse { jsonrpc: "2.0", id: Number(5867942540743301488), result: PutDeployResult { api_version: ProtocolVersion(SemVer { major: 1, minor: 0, patch: 0 }), deploy_hash: DeployHash(63e5be9a16dec27acddb0c32079a5515363176ed15a53aab645776cfdd62feb9) } }
2024-07-31T00:43:57.783511Z  INFO kairos_server::l1_sync::event_manager: Looking for new events
2024-07-31T00:44:07.783988Z  INFO kairos_server::l1_sync::event_manager: Looking for new events

marijanp · 2024-07-31T07:32:30Z

kairos-server/Cargo.toml

@@ -12,7 +12,8 @@ name = "kairos-server"
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

 [features]
-default = ["cctl-tests", "deposit-mock", "database"]
+# TODO readd database to default features once we have a nix module for postgres
+default = ["cctl-tests", "deposit-mock"]


we have a nix module for postgres

not one for the dev shell.

marijanp · 2024-07-31T07:35:30Z

kairos-server/src/config.rs

-            Some(secret_key_file) => {
-                if SecretKey::from_file(secret_key_file).is_err() {
-                    return Err("Invalid secret key".to_string());
+        let secret_key_file = parse_env_as_opt::<String>("KAIROS_SERVER_SECRET_KEY_FILE")?


Somehow I didn't see this earlier, where is this secret key file read from?

testdata in the root of the repo. see .env

koxu1996 · 2024-07-31T10:18:47Z

In this PR chainspec was updated - before, after - and the most important change is increasing max_memory limit from 64 to 640. That alone finally fixes withdraw functionality 😄.

Avi-D-coder added 4 commits July 30, 2024 13:11

Remove database from default features for now

051d11e

Make config parsing more robust

a18cd34

Test that the proof the server sends is valid in an integration test

843b214

It's not kairos it's cctl

c416dec

Avi-D-coder requested review from jonas089, marijanp and koxu1996 July 31, 2024 00:12

Avi-D-coder added 2 commits July 30, 2024 17:30

Fix cctl by using the exact same chainspec as the test execution envi…

c22f118

…ronment

Cleanup debug code

b92c9d9

Avi-D-coder changed the title ~~Debug cctl batch failing~~ Debug cctl batch failing (Ready to merge) Jul 31, 2024

marijanp reviewed Jul 31, 2024

View reviewed changes

koxu1996 mentioned this pull request Jul 31, 2024

Validate e2e #173

Closed

Merge branch 'main' into debug-cctl-batch-failing

678e2bf

marijanp approved these changes Aug 6, 2024

View reviewed changes

marijanp merged commit ed0ba18 into main Aug 6, 2024
4 checks passed

marijanp deleted the debug-cctl-batch-failing branch August 6, 2024 11:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Debug cctl batch failing (Ready to merge) #177

Debug cctl batch failing (Ready to merge) #177

Avi-D-coder commented Jul 31, 2024 •

edited

Loading

Avi-D-coder commented Jul 31, 2024

marijanp Jul 31, 2024

Avi-D-coder Jul 31, 2024

marijanp Jul 31, 2024

Avi-D-coder Jul 31, 2024

koxu1996 commented Jul 31, 2024

Debug cctl batch failing (Ready to merge) #177

Debug cctl batch failing (Ready to merge) #177

Conversation

Avi-D-coder commented Jul 31, 2024 • edited Loading

Avi-D-coder commented Jul 31, 2024

marijanp Jul 31, 2024

Choose a reason for hiding this comment

Avi-D-coder Jul 31, 2024

Choose a reason for hiding this comment

marijanp Jul 31, 2024

Choose a reason for hiding this comment

Avi-D-coder Jul 31, 2024

Choose a reason for hiding this comment

koxu1996 commented Jul 31, 2024

Avi-D-coder commented Jul 31, 2024 •

edited

Loading