Dynamic chainname fetch #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marijanp
reviewed
Jul 30, 2024
| Ok(Json(chain_name)) | ||
| } | ||
|
|
||
| pub async fn get_chain_name_from_rpc(rpc_url: &str) -> Result<String, ()> { |
There was a problem hiding this comment.
Would prefer to see rpc_url: &Url
There was a problem hiding this comment.
As you wish: dd881f6.
marijanp
approved these changes
Jul 30, 2024
Avi-D-coder
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets rid of
CASPER_CHAIN_NAMEenv variable - it gets fetched dynamically from RPC. In the future we could introduce cache for it.