Add missing tests for Deploy Notifier (SSE) #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are returned by public API, so should be public too.
Previously it was `StreamExhausted` which caused confusion.
Avi-D-coder
approved these changes
Jul 11, 2024
marijanp
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Mocking makes it difficult to detect regressions, and IMO does not provide any evidence that it's actually working: https://cs-syd.eu/posts/2021-10-22-why-mocking-is-a-bad-idea
|
@marijanp Provided tests with mocks are mostly the evidence that edge cases are handled according to my expectations: scenarios like double handshake should never happen. Of course we need integration tests to have higher confidence that code is actually working. If I have time I will experiment with running NCTL for notifier tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85.