Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the deposit check and withdrawals in the contract #144

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

Avi-D-coder
Copy link
Contributor

@Avi-D-coder Avi-D-coder commented Jul 9, 2024

tests are still failing and we now expect failures of the large prop test batches after verification. Making the randomly generated batches correctly deposit to the l1 in the tests is quite difficult, for now that's out of scope for this pr.

@Avi-D-coder Avi-D-coder marked this pull request as ready for review July 9, 2024 19:50
@Avi-D-coder Avi-D-coder requested review from marijanp and jonas089 July 9, 2024 19:50
@marijanp marijanp merged commit a860f25 into main Jul 10, 2024
4 checks passed
@marijanp marijanp deleted the feature/contract-deposit-window-withdraws branch July 10, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants