Caleb/dev #28
Open
Caleb/dev #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code runs OK here, and looks good to me. It might be your machine. |
pragdave
reviewed
Oct 15, 2016
| def counter(value \\ 0) do | ||
| receive do |
There was a problem hiding this comment.
-2 layout
The indentation of line 34 is deceptive. It's really part of the {:next, from} handler, and should share indentation with line 33.
| def new_counter(value) do | ||
| Agent.start_link(fn -> value end) | ||
| end | ||
| def next_value({:ok, counter}) do |
There was a problem hiding this comment.
-4 idiomatic
new_counter currently returns {:ok, pid}, which is why you have to pattern match in next_value. But the :ok part is only used inside new_counter—it shouldn't leak out. So write something like
def new_counter(value) do
{ :ok, count } = Agent.start_link(fn -> value end)
count
end| def pmap(collection, process_count, function) do | ||
| « your code here » | ||
| chunk_size = Enum.count(collection) / process_count |
There was a problem hiding this comment.
30
fyi: you could use div here, and replace map |> concat with flat_map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name: Caleb Kyle
SMU ID: 38045609
Question: On the fourth test of ex03, sometimes it will pass, other times it won't pass. Does this mean that I'm only using one core and sometimes the 2 chunk process just finishes faster? Why is it not consistently one way or the other?