-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work Done #26
base: master
Are you sure you want to change the base?
Work Done #26
Conversation
|
||
end | ||
|
||
def new_counter(a) do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-10
You were supposed to add the new_counter and next_value functions in the Ex01 module, but you added them to the tests.
Then, because the tests failed, you updated the tests to make it work.
You can't change the tests: they are the specification you're supposed to be implementing.
Agent.start( fn -> value end) | ||
end | ||
|
||
def next_value({:ok, count}) do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-5 for part 1, -3 for part 2
You use get followed by update. This is a bug.
Imagine there were two processes accessing the same counter at the same time. They both get the current value, then both add one to it and store it back.
As a result, the two processes both get the same value of the counter.
I lost total 18 points in this assignment, so my score must be 62/80. But on canvas I got 56/80. Please note this and I request you to update my score on canvas. |
You are correct. In my grading sheet, I had also deducted 6 points in Ex03,
but looking at the code I don't see why. I must have mistyped it.
I've added those six points back.
Good catch.
…On Tue, Nov 29, 2016 at 11:34 AM, darshan4694 ***@***.***> wrote:
I lost total 18 points in this assignment, so my score must be 62/80. But
on canvas I got 56/80. Please note this and I request you to update my
score on canvas.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAApmNlViAKldK2v5e9uJZ5jdC4r6bc8ks5rDGJBgaJpZM4KVbBV>
.
|
Thank you so much Sir. |
Name: Darshan Shah
SMU ID # 46916705