David kim #21
Open
David kim #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pragdave
reviewed
Sep 21, 2016
| @@ -36,7 +36,7 @@ defmodule Ex01 do | |||
| # Write a function that adds two numbers using fn syntax # | |||
| ########################################################## | |||
|
|
|||
| sum2a = your_anonymous_function(1, 2) | |||
| sum2a = fn(num1, num2) -> num1 + num2 end | |||
| @@ -47,7 +47,7 @@ defmodule Ex01 do | |||
| # Write a function that adds two numbers using & syntax # | |||
| ########################################################## | |||
|
|
|||
| sum2b = your_anonymous_function(1, 2) | |||
| sum2b = &(&1 + &2) | |||
| @@ -60,7 +60,7 @@ defmodule Ex01 do | |||
| # no explicit + operators in your function # | |||
| ##################################################################### | |||
|
|
|||
| sum3a = your_anonymous_function(1, 2, 3) | |||
| sum3a = fn(num1, num2, num3) -> sum2b.(num1, sum2b.(num2, num3)) end | |||
| @@ -71,7 +71,7 @@ defmodule Ex01 do | |||
| # Do the same using the & notation # | |||
| #################################### | |||
|
|
|||
| sum3b = your_anonymous_function | |||
| sum3b = &(sum2b.(&1, sum2b.(&2, &3))) | |||
| @@ -86,7 +86,9 @@ defmodule Ex01 do | |||
| # function. The examples below will make this clearer :) # | |||
| ######################################################################## | |||
|
|
|||
| create_adder = your_anonymous_function(1) | |||
| create_adder = fn(add_num) -> | |||
| # | ||
| # end | ||
| # end | ||
| def list_equal(list1, list2) do |
There was a problem hiding this comment.
0
Even if you were allowed to use Enum.at, it is generally a smell to use it with lists.
| @@ -149,7 +174,27 @@ defmodule Ex03 do | |||
| Think a little about a nice way to lay this code out. | |||
| """ | |||
|
|
|||
| def won . . . "your code" | |||
| def won(moves) do | |||
There was a problem hiding this comment.
3
This is really procedural code. think how it might look with pattern matching:
def won(position) do
case position do
{ a, a, a,
_, _, _,
_, _, _ } -> a
{ _, _, _,
a, a, a,
_, _, _ } -> a
{ _, _, _,
_, _, _,
a, a, a } -> a
{ a, _, _,
a, _, _,
a, _, _ } -> a
{ _, a, _,
_, a, _,
_, a, _ } -> a
{ _, _, a,
_, _, a,
_, _, a } -> a
{ a, _, _,
_, a, _,
_, _, a } -> a
{ _, _, a,
_, a, _,
a, _, _ } -> a
_ -> false
end
| return value will be the thing you have to manipulate. | ||
| """ | ||
|
|
||
| def even_odd(list) do |
There was a problem hiding this comment.
5
Several things hurt your mark here.
First, the partitioning is crying out to be in a new function. Second, you're using elem and list concatenation rather that pattern matching.
Here's an alternative;
def even_odd(list) do
reduce(list, { [], [] }, &assign_one_even_odd/2)
|> reverse_two_lists
end
defp assign_one_even_odd(number, { evens, odds }) do
cond do
Integer.is_even(number)->
{ [ number | evens ], odds }
Integer.is_odd(number) ->
{ evens, [ number | odds ] }
end
end
defp reverse_two_lists({ evens, odds }) do
{ reverse(evens), reverse(odds) }
end|
|
||
| def even_odd . . . "your code" | ||
| def min(list) do |
| -7 | ||
|
|
||
| """ | ||
| def reverse(list) do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
David Kim
40059634