Revamp redis plugin code and move to dzil #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If set in class, do not permit to call Dancer::Test and other case but main bin/app.pl
Doc is now up to date, Redis plugin is use with reconnect method.
Starter tess
The class key "PASSWORD" was use to fire AUTH. If I use multiple connection to different db with different password configuration it will failed. I move it to instance level, it should solve the problem.
Move RedisWithAuthSupport to real module on root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have rewrite the plugin with dzil migrating
Plugin dir should be simpler, and I remove the call to time each time we use redis key.
generally plugin is use like that :
my $redis = redis;
$redis->...
in that case ping / pong is call once.
Each time I test connection I try a ping, and return the result
I remove the anoying loosing connection, and just try to reconnect. In case fail, the program throw an exception.
A good think should be to have many server with try one, if fail try another ...
but not in this pull request,
tell me if you are interesting