Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib50 2.1, Windows support #194

Closed
wants to merge 13 commits into from
Closed

lib50 2.1, Windows support #194

wants to merge 13 commits into from

Conversation

Jelleas
Copy link
Contributor

@Jelleas Jelleas commented Sep 9, 2019

No description provided.

@dmalan
Copy link
Member

dmalan commented Jan 1, 2021

@Jelleas I didn't realize this was still pending, and I added readline back into develop (which had drifted from master). Are these good to be merged all together?

@Jelleas Jelleas closed this Jan 1, 2021
@Jelleas
Copy link
Contributor Author

Jelleas commented Jan 1, 2021

No this PR is stale and albeit undocumented is directly connected to another PR @ cs50/lib50#35. That in turn also grew stale and got closed last year.

I still believe it's ultimately worth the effort to try and get submit50/check50 to run under Windows at some point. But right now a lot of the underlying difficulties are tied to git and its need for a pseudoterminal for which there is seemingly little support under Windows. Given that git(Hub) might proof tricky to use soon, with the change to passwords, I'm not sure if it's worth the time/effort now.

@dmalan
Copy link
Member

dmalan commented Jan 1, 2021

Hm, so this PR was from develop. Should we move the latest master on top of develop so that they're back in sync then, then I'll re-add readline?

@Jelleas
Copy link
Contributor Author

Jelleas commented Jan 1, 2021

Ah, that explains. So beyond the Windows support part there are some commits in develop related to a custom honesty prompt. That happen to also be linked to a lib50 PR (cs50/lib50#60). That should go through, but I personally won't have time to fix it this week or the next.

So for now, do move master back on top of develop, and in the future we should stop merging commits into develop if they're depending on a PR elsewhere 😅

@dmalan
Copy link
Member

dmalan commented Jan 1, 2021

Okay, added back just readline for now if you want to re-PR with the requisite commits for lib50 when ready!

#250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants