-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib50 2.1, Windows support #194
Conversation
Add extra argument to prompt, ```question```, where the user can specify a custom honesty prompt if desired or a false-y value if the user does not want any honesty prompt.
add honesty prompt support
@Jelleas I didn't realize this was still pending, and I added |
No this PR is stale and albeit undocumented is directly connected to another PR @ cs50/lib50#35. That in turn also grew stale and got closed last year. I still believe it's ultimately worth the effort to try and get submit50/check50 to run under Windows at some point. But right now a lot of the underlying difficulties are tied to git and its need for a pseudoterminal for which there is seemingly little support under Windows. Given that git(Hub) might proof tricky to use soon, with the change to passwords, I'm not sure if it's worth the time/effort now. |
Hm, so this PR was from |
Ah, that explains. So beyond the Windows support part there are some commits in develop related to a custom honesty prompt. That happen to also be linked to a lib50 PR (cs50/lib50#60). That should go through, but I personally won't have time to fix it this week or the next. So for now, do move |
Okay, added back just |
No description provided.