Update __init__.py #232
Merged
Update __init__.py #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed test for "below range" to have it check input of 1 vs level of 2. (current test is for 0 which should be rejected due to not being positive) Added test for "non positive" input. to address: cs50/check50#328
rongxin-liu
approved these changes
Feb 26, 2024
|
Looks good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed test for "below range" to have it check input of 1 vs level of 2. (current test is for 0 which should be rejected due to not being positive)
Added test for "non positive" input.
to address: cs50/check50#328
@rongxin-liu I tested these changes but can you take another look? thanks.