-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
actions/pr-deployment: Fix deployment URL #19
Conversation
Shouldn't this PR affect the running action too? |
@gabrielmocanu, you know how this fucked up shit works. Should it? |
@teodutu, check the workflow file [1]. It shows that your change is applied, but it does not have the expected result. [1] https://github.com/cs-pub-ro/operating-systems/actions/runs/6693059404/workflow?pr=19 |
The URL was `http://open-education-hub.github.io/...`. This was incorrect for forked repos as it referred to the original owner: OEH. In addition, it was using the `http` scheme instead of `https`. This was less of an issue because the `http` endpoint redirects to `https`. This commit fixes both of the aforementioned problems by dynamically obtaining the owner uwing `${{ github.repository_owner }}` and by using `https` instead of `http`. Signed-off-by: Teodor Dutu <[email protected]>
38fbc44
to
d4c8289
Compare
You're right. I'll investigate. |
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target |
@teodutu no need for investigation, it works. |
Here to save your day, as always. |
The URL was
http://open-education-hub.github.io/...
. This was incorrect for forked repos as it referred to the original owner: OEH. In addition, it was using thehttp
scheme instead ofhttps
. This was less of an issue because thehttp
endpoint redirects tohttps
.This commit fixes both of the aforementioned problems by dynamically obtaining the owner uwing
${{ github.repository_owner }}
and by usinghttps
instead ofhttp
.